Skip to content

London | 26-ITP-May | Jorvan White | Sprint 2 | Wireframe#1320

Open
JorvanW wants to merge 5 commits into
CodeYourFuture:mainfrom
JorvanW:main
Open

London | 26-ITP-May | Jorvan White | Sprint 2 | Wireframe#1320
JorvanW wants to merge 5 commits into
CodeYourFuture:mainfrom
JorvanW:main

Conversation

@JorvanW
Copy link
Copy Markdown

@JorvanW JorvanW commented May 20, 2026 •
edited
Loading

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

This Pull request is for the wireframe project, ensuring that it meets the requirements.

@netlify
Copy link
Copy Markdown

netlify Bot commented May 20, 2026 •
edited
Loading

✅ Deploy Preview for cyf-onboarding-module ready!

Name Link
🔨 Latest commit 4cf50d2
🔍 Latest deploy log https://app.netlify.com/projects/cyf-onboarding-module/deploys/6a19c2f112d45e0008ce3049
😎 Deploy Preview https://deploy-preview-1320--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 2 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 86 (no change from production)
PWA: -
View the detailed breakdown and full score reports
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@JorvanW JorvanW added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 20, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 20, 2026
@github-actions

This comment has been minimized.

Sign in to view
@JorvanW
Copy link
Copy Markdown
Author

JorvanW commented May 20, 2026

When Committing changes from VSCode, the commits would go to my main branch instead of feature/wireframe branch. By the time I realised, for me to change it, the feature/wirerframe branch would show no consistent commits made. In the future I need to make sure the commits aren't being made to the main branch or to just create a new branch in VSCode.

@Poonam-raj
Copy link
Copy Markdown
Contributor

Poonam-raj commented May 22, 2026

Hi @JorvanW
Your GitHub Bot is still showing issues with the PR template you've submitted on this pull request. Please amend it following the GitHub Bot's suggestions.
Once you've fixed those issues and the bot passes, you will be able to add the "Needs Review" label to submit it for review

@JorvanW JorvanW added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 23, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 23, 2026
@Poonam-raj
Copy link
Copy Markdown
Contributor

Poonam-raj commented May 26, 2026 •
edited
Loading

Hi Jorvan, I think it might need your "Self checklist" to look like a H2 tag in the markdown. Or perhaps needs a H1 at the top of "Learners, PR Template"

@JorvanW
Copy link
Copy Markdown
Author

JorvanW commented May 26, 2026

Hello, I have just added the ## to Self Checklist. Would I need to re-add the needs review tag

@Poonam-raj
Copy link
Copy Markdown
Contributor

Poonam-raj commented May 26, 2026

Yes Jorvan - re-add it in, if in doubt, if it isn't in the labels section on the right hand side add it in :D

@JorvanW JorvanW added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 26, 2026
@JorvanW JorvanW mentioned this pull request May 26, 2026
Open
@LonMcGregor LonMcGregor added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels May 27, 2026
@cjyuan cjyuan added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels May 28, 2026
cjyuan
cjyuan reviewed May 28, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@cjyuan cjyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • According to https://validator.w3.org/, there are errors in your code. Can you fix them?

  • I noticed the following issues in the text content:

    • Some words are misspelled or use incorrect letter casing.
    • Some minor grammar mistakes.

    Could you run the content of your HTML document (including HTML code) through an AI tool to identify any potential improvements, even minor ones, to help ensure the content is fully polished?

  • In terms of the page layout, I'd like you to carefully compare your page against the wireframe and identify any differences in alignment, consistency of element sizing, and whether any elements from the wireframe are missing, omitted, or implemented differently.

    For examples,

    • Are all the text content properly centered or left-justified?
    • Are the articles centered on the page?
    • Between the two articles at the bottom of the page, do their image and title fully align horizontally?
    • Do all "Read more" links look identical?

    Once you've done that review, revisit your implementation and make adjustments where needed to bring the layout closer to the wireframe.

Comment thread Wireframe/index.html
Comment on lines 18 to 20
<p>
Lorem ipsum dolor sit amet consectetur adipisicing elit. Quisquam,
voluptates. Quisquam, voluptates.
ReadME file is a plain text document that is used as a user manual or official document for a project. This file is useful because it helps communicate important information to those using or collaborating the project.
</p>
Copy link
Copy Markdown
Contributor

@cjyuan cjyuan May 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: VS Code formatter could be used to keep our code consistently formatted, including breaking long
lines of HTML text into multiple lines for easier editing and maintenance.

As a best practice, consider following this guide to enable VS Code's
"Format on Save" option or to use its "Format Document" command to ensure your code is always consistently formatted.

Please note that code formatters may not work correctly when the source code contains syntax errors.

Comment thread Wireframe/index.html
Comment on lines +25 to +33
<h3>Wireframe</h3>
<p>
A wireframe is a minimal skeletal blueprint of a website or app interface. It is important in order to plan a project in advance.
</p>
<a href="https://balsamiq.com/blog/what-are-wireframes/">Read more</a>
</article>
<article>
<img src="https://miro.medium.com/v2/resize:fit:1100/format:webp/1*nQXC89lqQnqvICtb3J6XWw.png" alt="GitBranch" />
<h4>Git Branch </h4>
Copy link
Copy Markdown
Contributor

@cjyuan cjyuan May 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are the articles given different headings?

Could you look up how headings (h1 to h6) should be used in an HTML document?

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels May 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjyuan cjyuan cjyuan left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

Reviewed Volunteer to add when completing a review with trainee action still to take.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@JorvanW @Poonam-raj @cjyuan @LonMcGregor